lkml.org 
[lkml]   [2006]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 8/8] [GFS2] gfs2_dir_read_data(): fix uninitialized variable usage
    From
    Date
    >From b7d8ac3e1779c30ddef0a8f38042076c5007a23d Mon Sep 17 00:00:00 2001
    From: Adrian Bunk <bunk@stusta.de>
    Date: Thu, 19 Oct 2006 16:02:07 +0200
    Subject: [GFS2] gfs2_dir_read_data(): fix uninitialized variable usage

    In the "if (extlen)" case, "bh" was used uninitialized.

    This patch changes the code to what seems to have been intended.

    Spotted by the Coverity checker.

    This patch also removes a pointless "bh = NULL" asignment (the variable
    is never accessed again after this point).

    Signed-off-by: Adrian Bunk <bunk@stusta.de>
    Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
    ---
    fs/gfs2/dir.c | 4 +---
    1 files changed, 1 insertions(+), 3 deletions(-)

    diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
    index ead7df0..e24af28 100644
    --- a/fs/gfs2/dir.c
    +++ b/fs/gfs2/dir.c
    @@ -315,8 +315,7 @@ static int gfs2_dir_read_data(struct gfs
    if (!ra)
    extlen = 1;
    bh = gfs2_meta_ra(ip->i_gl, dblock, extlen);
    - }
    - if (!bh) {
    + } else {
    error = gfs2_meta_read(ip->i_gl, dblock, DIO_WAIT, &bh);
    if (error)
    goto fail;
    @@ -330,7 +329,6 @@ static int gfs2_dir_read_data(struct gfs
    extlen--;
    memcpy(buf, bh->b_data + o, amount);
    brelse(bh);
    - bh = NULL;
    buf += amount;
    copied += amount;
    lblock++;
    --
    1.4.1


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-20 11:15    [W:4.825 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site