Messages in this thread | | | Subject | Re: [PATCH 2.6.19-rc2] [REVISED 2] drivers/media/video/se401.c: check kmalloc() return value. | From | Alan Cox <> | Date | Fri, 20 Oct 2006 14:14:58 +0100 |
| |
Ar Iau, 2006-10-19 am 22:16 -0700, ysgrifennodd Amit Choudhary: > Description: Check the return value of kmalloc() in function se401_start_stream(), in file drivers/media/video/se401.c. > > Signed-off-by: Amit Choudhary <amit2030@gmail.com>
This actually isn't needed for the first case as SE401_NUMSBUF is 1 but the second fix is needed. Both are right and useful to merge in case NUMSBUF is ever changed.
If you know se401->sbuf[] and se401->scratch , urb etc are being cleared to NULL (or you did that) you could just use the kfree loops in nomem_ for all cases as kfree(NULL) is an allowed "no-op"
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |