lkml.org 
[lkml]   [2006]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch] dynticks: core, NMI watchdog fix, #2

Andrew, there's one more fallout of the dyntick queue: the fix below
goes after (or into) dynticks-core-nmi-watchdog-fix.patch. The bug only
affected NO_HZ kernels.

Ingo

----------------->
Subject: dynticks: core, NMI watchdog fix, #2
From: Ingo Molnar <mingo@elte.hu>

a partial fix of the NMI watchdog bug sneaked into yesterday night's
queue - this patch removes that extra in_interrupt() condition.

(One effect of this bug is a 'slow' serial console on NO_HZ, because we
never update jiffies and the serial console's timeouts get confused by
it.)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/softirq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/kernel/softirq.c
===================================================================
--- linux.orig/kernel/softirq.c
+++ linux/kernel/softirq.c
@@ -280,7 +280,7 @@ void irq_enter(void)
{
__irq_enter();
#ifdef CONFIG_NO_HZ
- if (idle_cpu(smp_processor_id()) && !in_interrupt())
+ if (idle_cpu(smp_processor_id()))
hrtimer_update_jiffies();
#endif
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-10-02 11:05    [W:2.539 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site