Messages in this thread | | | Date | Mon, 2 Oct 2006 12:47:22 -0500 | Subject | Re: [PATCH 6/6]: powerpc/cell spidernet refine locking | From | (Linas Vepstas) |
| |
On Fri, Sep 29, 2006 at 07:47:52PM -0700, Andrew Morton wrote: > On Fri, 29 Sep 2006 18:29:11 -0500 > linas@austin.ibm.com (Linas Vepstas) wrote: > > > The transmit side of the spider ethernet driver currently > > places locks around some very large chunks of code. This > > results in a fair amount of lock contention is some cases. > > This patch makes the locks much more fine-grained, protecting > > only the cirtical sections. One lock is used to protect > > three locations: the queue head and tail pointers, and the > > queue low-watermark location. > > You have spider_net_set_low_watermark() walking the tx_chain outside > tx_chain.lock. Are you sure about that?
Yes. Its making an approximate count of the queue length, and I figured that if its approximate to begin with, an unlocked version should be just fine.
--linas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |