Messages in this thread | | | Date | Thu, 19 Oct 2006 18:06:59 -0500 | From | Olof Johansson <> | Subject | Re: [RFC][PATCH] Xilinx uartlite serial driver |
| |
On Wed, 13 Sep 2006 15:39:09 +0200 Peter Korsgaard <jacmet@sunsite.dk> wrote:
> +static int __devinit ulite_probe(struct platform_device *pdev) [...] > + port = &ports[pdev->id]; > + > + port->fifosize = 16; > + port->regshift = 2; > + port->iotype = UPIO_MEM; > + port->iobase = 1; /* mark port in use */ > + port->mapbase = res->start; > + port->membase = 0; > + port->ops = &ulite_ops; > + port->irq = res2->start; > + port->flags = UPF_BOOT_AUTOCONF; > + port->dev = &pdev->dev; > + port->type = PORT_UNKNOWN;
Hi Peter,
You never fill in the 'line' member here, so probing of a second uartlite port will fail.
Add: port->line = pdev->id;
-Olof - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |