lkml.org 
[lkml]   [2006]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: fs/Kconfig question regarding CONFIG_BLOCK
    On Wed, 18 Oct 2006 09:09:22 +0200 Jens Axboe wrote:

    > On Tue, Oct 17 2006, Jan Engelhardt wrote:
    > > >> Never mind, I see that some filesystems have 'depends on BLOCK' instead
    > > >> of being wrapped into if BLOCK. Not really consistent but whatever.
    > > >
    > > >Feel free to send in patches that make things more consistent.
    > >
    > > How would you like things? if BLOCK or depends on BLOCK?
    >
    > Well, if you can hide an entire block with if BLOCK, then that would be
    > preferred. Otherwise depends on BLOCK.
    >
    > > Does menuconfig/oldconfig/etc. parse the whole config structure faster
    > > it it done either way?
    >
    > I'd be surprised if if BLOCK wasn't faster over, say, 10 depends on
    > BLOCK.

    Jens,
    Has anyone looked at what BLOCK=n does to mm/page-writeback.c ?
    It calls blk_congestion_end(), which isn't there.

    mm/built-in.o: In function `writeback_congestion_end':
    (.text.writeback_congestion_end+0xc): undefined reference to `blk_congestion_end'
    make: *** [.tmp_vmlinux1] Error 1
    Command exited with non-zero status 2


    ---
    ~Randy
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-18 19:59    [W:0.026 / U:30.792 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site