Messages in this thread | | | Subject | Re: [PATCH 0/5] Allow more than PAGESIZE data read in configfs | From | Chandra Seetharaman <> | Date | Mon, 16 Oct 2006 12:24:35 -0700 |
| |
On Sat, 2006-10-14 at 13:10 -0700, Joel Becker wrote: > On Sat, Oct 14, 2006 at 12:43:51PM -0700, Andrew Morton wrote: > > On Sat, 14 Oct 2006 01:01:07 -0700 > > Greg KH <greg@kroah.com> wrote: > > > Argh!!!! > > > > > > Are you going to honestly tell me you have a single attribute in sysfs > > > that is larger than PAGE_SIZE? > > > > He does not. It's a matter of reusing existing facilities rather than > > impementing similar things in multiple places. The equivalent patch in > > configfs removed a decent amount of code: > > Issues of PAGE_SIZE and attribute size aside, the patch posted > was incorrect. While they used seq_file, they implemented it in a
I do not think it is incorrect. It provides a simplest interface to configfs's clients.
> completely inefficent fashion, filling the entire buffer in one ->show() > call rather than letting multiple read(2) calls iterate their list.
So, are you suggesting that we should provide a generic seq_operations interface to configfs's clients ?
> > Joel > --
---------------------------------------------------------------------- Chandra Seetharaman | Be careful what you choose.... - sekharan@us.ibm.com | .......you may get it. ----------------------------------------------------------------------
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |