lkml.org 
[lkml]   [2006]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] i386 Time: Avoid PIT SMP lockups
Date
On Monday 16 October 2006 20:39, Andrew Morton wrote:
> On 16 Oct 2006 15:48:02 +0200
> Andi Kleen <ak@suse.de> wrote:
>
> > Andrew Morton <akpm@osdl.org> writes:
> > >
> > > Is there any actual need to hold xtime_lock while doing the port IO? I'd
> > > have thought it would suffice to do
> > >
> > > temp = port_io
> > > write_seqlock(xtime_lock);
> > > xtime = muck_with(temp);
> > > write_sequnlock(xtime_lock);
> > >
> > > ?
> >
> > That would be a good idea in general. The trouble is just that whatever race
> > is there will be still there then, just harder to trigger (so instead of
> > every third boot it will muck up every 6 weeks). Not sure that is
> > a real improvement.
> >
>
> Confused. What race are you referring to?

Sorry s/race/starvation/

>
> This is addressing a starvation problem which is due to the slowness of the
> port-io (iirc).

Is it just sure to go away when the critical section is shorter?

-Andi



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-16 20:45    [W:0.308 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site