Messages in this thread | | | Subject | Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set | From | Alan Cox <> | Date | Sun, 15 Oct 2006 22:52:15 +0100 |
| |
Ar Sul, 2006-10-15 am 10:45 -0700, ysgrifennodd Andrew Morton: > If the drivers doesn't care and if it makes no difference to performance > then just delete the call to pci_set_mwi(). > > But if MWI _does_ make a difference to performance then we should tell > someone that it isn't working rather than silently misbehaving?
It isn't misbehaving it just isn't available. MWI is rather different to say pci_set_master() in that it makes a lot of sense for many drivers to ask for it but not care about the results. Something like pci_set_master failing is a big problem and has to be handled (although as we often don't use BIOS PCI services we see fake success in some cases).
MWI is an "extra cheese" option not a "no pizza" case
Alan
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |