Messages in this thread | | | Date | Fri, 13 Oct 2006 14:56:58 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 3/3] Add support for the generic backlight device to the TOSHIBA ACPI driver |
| |
On Fri, 13 Oct 2006 12:24:19 +0200 Holger Macht <hmacht@suse.de> wrote:
> +static int set_lcd(int value) > +{ > + u32 hci_result; > + > + value = value << HCI_LCD_BRIGHTNESS_SHIFT; > + hci_write1(HCI_LCD_BRIGHTNESS, value, &hci_result); > + if (hci_result != HCI_SUCCESS) > + return -EFAULT; > + > + return 0;
-EFAULT seems a bit random. Would -EIO be more appropriate? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |