lkml.org 
[lkml]   [2006]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] hwmon/abituguru: handle sysfs errors
Date
On Tuesday 10 October 2006 05:34, Jean Delvare wrote:
> Hans,
>
> > > * We want to delete all the device files at regular cleanup time (after
> > > unregistering with the hwmon class).
> >
> > Is this really nescesarry? AFAIK the files get deleted when the device
> > gets deleted.
>
> The point is that the device shouldn't be deleted if we were following
> the device driver model. After all the uGuru device exists in your
> system before the abituguru driver is loaded, and is still there after
> the driver is unloaded.
>
> Now I agree that for now it won't make a difference, be we are
> preparing for the future, and all other hardware monitoring drivers
> were updated that way already.
>
> > > * It's OK to call device_create_file() on a non-existent file, so the
> > > error path can be simplified.
> >
> > ?? You mean device_remove_file I assume?
>
> Oops, yes, that was a typo, sorry.
>

I know I sound like a roken record but this driver would benefit from
using attribute_group.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-12 06:33    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean