Messages in this thread | | | Date | Thu, 12 Oct 2006 17:01:03 +1000 | From | Nick Piggin <> | Subject | Re: [RFC][PATCH] EXT3: problem with page fault inside a transaction |
| |
Andrew Morton wrote: > On Thu, 12 Oct 2006 09:57:26 +0400 > Dmitriy Monakhov <dmonakhov@openvz.org> wrote: > > >>While reading Andrew's generic_file_buffered_write patches i've remembered >>one more EXT3 issue.journal_start() in prepare_write() causes different ranking >>violations if copy_from_user() triggers a page fault. It could cause >>GFP_FS allocation, re-entering into ext3 code possibly with a different >>superblock and journal, ranking violation of journalling serialization >>and mmap_sem and page lock and all other kinds of funny consequences. > > > With the stuff Nick and I are looking at, we won't take pagefaults inside > prepare_write()/commit_write() any more.
Yep. Because the page is locked, it is too much to deal with even without a filesystem in the picture.
-- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |