lkml.org 
[lkml]   [2006]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2/5] mm: fault vs invalidate/truncate race fix


On Thu, 12 Oct 2006, Nick Piggin wrote:
>
> > Are you saying that something like this would be preferable?
>
> I think so, it is neater and clearer. I actually didn't even bother relocking
> and checking the page again on readpage error so got rid of quite a bit of
> code.

Well, the readpage error should be rare (and for the _normal_ case we just
do the "wait_on_page_locked()" thing). And I think we should lock the page
in order to do the truncation check, no?

But I don't have any really strong feelings. I'm certainly ok with the
patch I sent out. How about putting it through -mm? Here's my sign-off:

Signed-off-by: Linus Torvalds <torvalds@osdl.org>

if you want to send it off to Andrew (or if Andrew wants to just take it
himself ;)

Btw, how did you even notice this? Just by reading the source, or because
you actually saw multiple errors reported?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [from the cache]
©2003-2011 Jasper Spaans