Messages in this thread | | | Subject | Re: [PATCH 21/21]: powerpc/cell spidernet DMA coalescing | From | Benjamin Herrenschmidt <> | Date | Wed, 11 Oct 2006 17:15:10 +1000 |
| |
On Tue, 2006-10-10 at 18:20 -0500, jschopp wrote: > Linas Vepstas wrote: > > The current driver code performs 512 DMA mappns of a bunch of > > 32-byte structures. This is silly, as they are all in contiguous > > memory. Ths patch changes the code to DMA map the entie area > > with just one call. > > > > Signed-off-by: Linas Vepstas <linas@austin.ibm.com> > > Cc: James K Lewis <jklewis@us.ibm.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > The others look good, but this one complicates the code and doesn't have any benefit. 20 > for 21 isn't bad.
Hi Joel !
I'm not sure what you mean here.... (especially your 20 to 21 comment).
The patch looks perfectly fine to me, and in fact removes more lines of code than it adds :)
Cheers, Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |