Messages in this thread | | | Subject | Re: [PATCH] I2O: more error checking | From | Alan Cox <> | Date | Thu, 12 Oct 2006 00:06:28 +0100 |
| |
Ar Mer, 2006-10-11 am 17:41 -0400, ysgrifennodd Jeff Garzik: > i2o_scsi: handle sysfs failure > > i2o_device: > * convert i2o_device_add() to return integer error code
NAK, Fix the comments to match the code changes.
> diff --git a/drivers/message/i2o/device.c b/drivers/message/i2o/device.c > index ee18305..5f2c317 100644 > --- a/drivers/message/i2o/device.c > +++ b/drivers/message/i2o/device.c > @@ -217,15 +217,15 @@ static struct i2o_device *i2o_device_all > * Returns a pointer to the I2O device on success or negative error code > * on failure. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> */ > -static struct i2o_device *i2o_device_add(struct i2o_controller *c, > - i2o_lct_entry * entry) > +static int i2o_device_add(struct i2o_controller *c, i2o_lct_entry *entry) > {
Otherwise Ack.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |