lkml.org 
[lkml]   [2006]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/5] Allow more than PAGESIZE data read in configfs
On Wed, Oct 11, 2006 at 01:19:35PM -0700, Andrew Morton wrote:
> The patch deletes a pile of custom code from configfs and replaces it with
> calls to standard kernel infrastructure and fixes a shortcoming/bug in the
> process. Migration over to the new interface is trivial and almost
> scriptable.
>
> Nice patch. What's not to like about it??

We're discussing it both online and offline because there are
concerns they have that do need to be addressed.
What's not to like? If you need more than 4K to display an
attribute, odds are you have more than one attribute in the file, which
is Wrong. These guys, it turns out, don't, which is why I'm trying to
help them. But I don't want to encourage others to do the wrong thing.
I'm also unhappy with the lack of symmetry this creates on the
store/show() prototypes. We're discussing whether the store() side
should support larger-than-a-page writes, and how to do it.

Joel

--

"Conservative, n. A statesman who is enamoured of existing evils,
as distinguished from the Liberal, who wishes to replace them
with others."
- Ambrose Bierce, The Devil's Dictionary

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-11 23:45    [from the cache]
©2003-2011 Jasper Spaans