lkml.org 
[lkml]   [2006]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 06/67] Video: cx24123: fix PLL divisor setup

    -stable review patch. If anyone has any objections, please let us know.

    ------------------
    From: Yeasah Pell <yeasah@schwide.net>

    The cx24109 datasheet says: "NOTE: if A=0, then N=N+1"

    The current code is the result of a misinterpretation of the datasheet to
    mean exactly the opposite of the requirement -- The actual value of N is 1
    greater than the value written when A is 0, so 1 needs to be *subtracted*
    from it to compensate.

    Signed-off-by: Yeasah Pell <yeasah@schwide.net>
    Signed-off-by: Steven Toth <stoth@hauppauge.com>
    Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/media/dvb/frontends/cx24123.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- linux-2.6.18.orig/drivers/media/dvb/frontends/cx24123.c
    +++ linux-2.6.18/drivers/media/dvb/frontends/cx24123.c
    @@ -549,8 +549,8 @@ static int cx24123_pll_calculate(struct
    ndiv = ( ((p->frequency * vco_div * 10) / (2 * XTAL / 1000)) / 32) & 0x1ff;
    adiv = ( ((p->frequency * vco_div * 10) / (2 * XTAL / 1000)) % 32) & 0x1f;

    - if (adiv == 0)
    - ndiv++;
    + if (adiv == 0 && ndiv > 0)
    + ndiv--;

    /* control bits 11, refdiv 11, charge pump polarity 1, charge pump current, ndiv, adiv */
    state->pllarg = (3 << 19) | (3 << 17) | (1 << 16) | (pump << 14) | (ndiv << 5) | adiv;
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-11 23:39    [W:0.021 / U:0.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site