Messages in this thread | | | Date | Wed, 11 Oct 2006 07:41:57 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH] i2c/buses/scx200_acb: handle PCI errors |
| |
Hi Jeff,
> drivers/i2c/busses/scx200_acb.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c > index 32aab0d..714bae7 100644 > --- a/drivers/i2c/busses/scx200_acb.c > +++ b/drivers/i2c/busses/scx200_acb.c > @@ -494,11 +494,12 @@ static __init int scx200_create_pci(cons > iface->pdev = pdev; > iface->bar = bar; > > - pci_enable_device_bars(iface->pdev, 1 << iface->bar); > + rc = pci_enable_device_bars(iface->pdev, 1 << iface->bar); > + if (rc) > + goto errout_free; > > rc = pci_request_region(iface->pdev, iface->bar, iface->adapter.name); > - > - if (rc != 0) { > + if (rc) { > printk(KERN_ERR NAME ": can't allocate PCI BAR %d\n", > iface->bar); > goto errout_free;
Looks good, applied, thanks.
-- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |