lkml.org 
[lkml]   [2006]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Hugepage regression
    On Tue, 10 Oct 2006 18:47:48 +1000
    David Gibson <david@gibson.dropbear.id.au> wrote:

    > It seems commit fe1668ae5bf0145014c71797febd9ad5670d5d05 causes a
    > hugepage regression. A git bisect points the finger at that commit
    > for causing an oops in the 'alloc-instantiate-race' test from the
    > libhugetlbfs testsuite.
    >
    > Still looking to determine the reason it breaks things.
    >

    It's assuming that unmap_hugepage_range() is always freeing these pages.
    If the page is shared by another mapping, bad things will happen: the
    threads fight over page->lru.

    Doing

    + if (page_count(page) == 1)
    list_add(&page->lru, &page_list);

    might help. But then we miss the tlb flush in rare racy conditions.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-10 11:09    [W:0.031 / U:210.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site