lkml.org 
[lkml]   [2006]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] netlink oops fix due to incorrect error code
    Fixed oops after failed netlink socket creation.
    Wrong parathenses in if() statement caused err to be 1,
    instead of negative value.
    Trivial fix, not trivial to find though.

    Signed-Off-By: Dmitry Mishin <dim@sw.ru>
    Signed-Off-By: Kirill Korotaev <dev@openvz.org>

    Kirill
    P.S. against 2.6.15

    --- ./net/netlink/af_netlink.c.nlfix 2006-01-06 18:37:28.000000000 +0300
    +++ ./net/netlink/af_netlink.c 2006-01-09 16:40:49.000000000 +0300
    @@ -416,7 +416,7 @@ static int netlink_create(struct socket
    groups = nl_table[protocol].groups;
    netlink_unlock_table();

    - if ((err = __netlink_create(sock, protocol) < 0))
    + if ((err = __netlink_create(sock, protocol)) < 0)
    goto out_module;

    nlk = nlk_sk(sock->sk);
    \
     
     \ /
      Last update: 2006-01-09 15:44    [W:0.017 / U:61.468 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site