Messages in this thread | | | Date | Sun, 8 Jan 2006 19:53:23 -0800 | From | Greg KH <> | Subject | Re: i2c/ smbus question |
| |
On Mon, Jan 09, 2006 at 09:58:22AM +1100, Benjamin Herrenschmidt wrote: > On Sun, 2006-01-08 at 11:30 +0100, Jean Delvare wrote: > > > The i2c_smbus_write_i2c_block_data wrapper function used to be defined, > > but was removed in 2.6.10-rc2 together with a couple other similar > > wrappers [1] on request by Adrian Bunk, the reason being that they had > > no user back then. I was a bit reluctant at first, but we finally agreed > > with Adrian to remove the functions, and to reintroduce them later if > > they were ever needed. > > Argh... Adrian, sometimes I hate you ;-) > > > So, if you need i2c_smbus_write_i2c_block_data(), we can easily > > resurrect it. See the patch below. I made the new version a bit faster > > (I hope) than the original by using memcpy, please confirm it works for > > you. > > Seems to work. Greg, would you mean boucing that to Linus asap (if you > are ok with it of course) ? I have a pile of patch about to hit him via > the powerpc merge git tree and I'll "fix" some of the mac drivers in > there to use that wrapper, so without that patch, g5 won't build ;)
Sure, Jean, care to resend it to me, as it's now lost in my archives somewhere :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |