lkml.org 
[lkml]   [2006]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/15] kconf: Check for eof from input stream.
On Sun, 2006-01-08 at 17:34 +0100, Roman Zippel wrote:
> Hi,
>
> On Wednesday 04 January 2006 23:01, Ben Collins wrote:
>
> > +static char *fgets_check_stream(char *s, int size, FILE *stream)
> > +{
> > + char *ret = fgets(s, size, stream);
> > +
> > + if (ret == NULL && feof(stream)) {
> > + printf(_("aborted!\n\n"));
> > + printf(_("Console input is closed. "));
> > + printf(_("Run 'make oldconfig' to update configuration.\n\n"));
> > + exit(1);
> > + }
> > +
> > + return ret;
> > +}
>
> What problem does this solve? conf should finish normally anyway and just set
> everything to the default.

It shouldn't, and it doesn't (that's what defconfig does, I believe).

Anyway, the problem is that if there is no terminal (e.g. stdout is
redirected to a file, and stdin is closed), then kconf loops forever
trying to get an answer (NULL is not the same as "").

--
Ben Collins <ben.collins@ubuntu.com>
Developer
Ubuntu Linux

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-01-08 19:55    [W:0.051 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site