Messages in this thread | | | Date | Sat, 07 Jan 2006 00:43:32 +0100 | From | Pierre Ossman <> | Subject | Re: [PATCH] [MMC] Minimise protocol awareness in Au1x00 driver |
| |
Pierre Ossman wrote: > The Au1x00 MMC/SD driver currently contains switch statements based on > protocol opcodes, not on desired behaviour. > > Unfortunately the AMD specification is not detailed enough to determine > how the controller will behave for the response settings. For now, it will > have to suffice to warn when we have an unknown response type. > > Signed-off-by: Pierre Ossman <drzeus@drzeus.cx> > --- > >
Whilst doing this I also noticed how horribly broken this driver is with regard to sending the stop command. Instead of sending the requested command it sends a hard coded opcode!! Jordan, please fix this ASAP.
Rgds Pierre
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |