lkml.org 
[lkml]   [2006]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] media-radio: Pci probing for maestro radio
Date
From
Dnia 04-01-2006 o 10:45:32 Andrew Morton <akpm@osdl.org> napisał:

> "Jiri Slaby" <xslaby@fi.muni.cz> wrote:
>>
>> + retval = video_register_device(maestro_radio_inst, VFL_TYPE_RADIO,
>> + radio_nr);
>> + if (retval) {
>> + printk(KERN_ERR "can't register video device!\n");
>> + goto errfr1;
>> + }
>> +
>> + if (!radio_power_on(radio_unit)) {
>> + retval = -EIO;
>
> Shouldn't we unregister the video device here?

Current behaviour means that device is here but not functioning properly
but
we can unregister it of course because it is useless anyway ;-).

Regards
--
Adam Tlałka mailto:atlka@pg.gda.pl ^v^ ^v^ ^v^
System & Network Administration Group ~~~~~~
Computer Center, Gdańsk University of Technology, Poland
PGP public key: finger atlka@sunrise.pg.gda.pl
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-01-04 10:55    [from the cache]
©2003-2011 Jasper Spaans