lkml.org 
[lkml]   [2006]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] media-radio: Pci probing for maestro radio
"Jiri Slaby" <xslaby@fi.muni.cz> wrote:
>
> + retval = video_register_device(maestro_radio_inst, VFL_TYPE_RADIO,
> + radio_nr);
> + if (retval) {
> + printk(KERN_ERR "can't register video device!\n");
> + goto errfr1;
> + }
> +
> + if (!radio_power_on(radio_unit)) {
> + retval = -EIO;

Shouldn't we unregister the video device here?

> + goto errfr1;
> + }
> +
> + dev_info(&pdev->dev, "version " DRIVER_VERSION " time " __TIME__ " "
> + __DATE__ "\n");
> + dev_info(&pdev->dev, "radio chip initialized\n");
> +
> + return 0;
> +errfr1:
> + kfree(maestro_radio_inst);
> +errfr:
> + kfree(radio_unit);
> +err:
> + return retval;
> +
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-01-04 10:48    [W:0.083 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site