Messages in this thread | | | Date | Wed, 4 Jan 2006 13:15:26 -0800 | From | Greg KH <> | Subject | Re: [stable] Re: [Patch 2.6] dm-crypt: zero key before freeing it |
| |
On Wed, Jan 04, 2006 at 12:43:21PM -0800, Randy.Dunlap wrote: > On Wed, 4 Jan 2006, J?rn Engel wrote: > > > On Wed, 4 January 2006 12:28:59 -0800, Randy.Dunlap wrote: > > > On Wed, 4 Jan 2006, Stefan Rompf wrote: > > > > Am Mittwoch 04 Januar 2006 21:09 schrieb Arjan van de Ven: > > > > > > > > > since a memset right before a free is a very unusual code pattern in the > > > > > kernel it may well be worth putting a short comment around it to prevent > > > > > someone later removing it as "optimization" > > > > > > > > Valid objection, here is an update (and see, I'm running 2.6.15 now ;-) > > > > > > A reason "why" would be more helpful that a "what". > > > > "prevent information leak" > > > > This is still a "what", but at least not a "how". > > OK, that's a much better changelog entry or source code comment... > if it could be put in one of those places.
Yes, Stefan, care to redo this with an updated changelog command?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |