lkml.org 
[lkml]   [2006]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 05/13] spufs fix spu_acquire_runnable error path
    When spu_activate fails in spu_acquire_runnable, the
    state must still be SPU_STATE_SAVED, we were
    incorrectly setting it to SPU_STATE_RUNNABLE.

    Signed-off-by: Arnd Bergmann <arndb@de.ibm.com>

    Index: linux-2.6.15-rc/arch/powerpc/platforms/cell/spufs/context.c
    ===================================================================
    --- linux-2.6.15-rc.orig/arch/powerpc/platforms/cell/spufs/context.c
    +++ linux-2.6.15-rc/arch/powerpc/platforms/cell/spufs/context.c
    @@ -132,10 +132,10 @@ int spu_acquire_runnable(struct spu_cont

    if (ctx->state == SPU_STATE_SAVED) {
    ret = spu_activate(ctx, 0);
    + if (ret)
    + goto out;
    ctx->state = SPU_STATE_RUNNABLE;
    }
    - if (ret)
    - goto out;

    downgrade_write(&ctx->state_sema);
    /* On success, we return holding the lock */
    --

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-04 21:00    [W:3.464 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site