Messages in this thread | | | Date | Tue, 31 Jan 2006 23:16:37 +0100 | From | Adrian Bunk <> | Subject | Re: 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error |
| |
On Tue, Jan 31, 2006 at 04:58:09PM +0200, Denis Vlasenko wrote: > On Tuesday 31 January 2006 16:54, John W. Linville wrote: > > On Tue, Jan 31, 2006 at 02:16:05PM +0200, Denis Vlasenko wrote: > > > > > CONFIG_ACX=y > > > # CONFIG_ACX_PCI is not set > > > # CONFIG_ACX_USB is not set > > > > > > This won't fly. You must select at least one. > > > > > > Attached patch will check for this and #error out. > > > Andrew, do not apply to -mm, I'll send you bigger update today. > > > > Is there any way to move this into a Kconfig file? That seems nicer > > than having #ifdefs in source code to check for a configuration error. > > Can't think of any at the moment.
There are two possible solutions ("offer" means "is user visible"): - only offer ACX and always build ACX_PCI/ACX_USB depending on the availability of PCI/USB - only offer ACX_PCI and ACX_USB which select ACX
If you tell me which you prefer I can send a patch.
> vda
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |