Messages in this thread | | | Date | Tue, 31 Jan 2006 00:39:27 +0900 (JST) | Subject | Re: [PATCH] serial: Add spin_lock_init() in 8250 early_serial_setup() to init port.lock | From | Atsushi Nemoto <> |
| |
>>>>> On Wed, 25 Jan 2006 22:24:03 -0500, "George G. Davis" <gdavis@mvista.com> said:
gdavis> Need spin_lock_init(&serial8250_ports[port->line].port.lock) gdavis> in early_serial_setup() since we're copying struct uart_port gdavis> *port into serial8250_ports[port->line].port and *port.lock is gdavis> typically unitiliased by the caller.
Is this really needed? The port.lock will be initialized in uart_set_options() or uart_add_one_port().
I think spin_lock_init() in serial8250_isa_init_ports() can be omitted also.
--- Atsushi Nemoto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |