Messages in this thread | | | Date | Mon, 30 Jan 2006 12:54:36 +0100 | From | Jan Blunck <> | Subject | Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super |
| |
On Mon, Jan 23, Kirill Korotaev wrote:
> Jan, I still have not heard a single comment about what's wrong with > it... I would really appreciate if you provide me one. >
Sorry for the delay. I had to fix a totally bogus patch (mine ;).
The problem with your patch is that it hides too early mntput's. Think about following situation:
mntput(path->mnt); // too early mntput() dput(path->dentry);
Assuming that in-between this sequence someone unmounts the file system, your patch will wait for this dput() to finish before it proceeds with unmounting the file system. I think this isn't what we want.
Regards, Jan
-- Jan Blunck jblunck@suse.de SuSE LINUX AG - A Novell company Maxfeldstr. 5 +49-911-74053-608 D-90409 Nürnberg http://www.suse.de - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |