Messages in this thread | | | Date | Sun, 29 Jan 2006 00:19:04 +0530 | From | Dipankar Sarma <> | Subject | Re: [PATCH] rcu_process_callbacks: don't cli() while testing ->nxtlist |
| |
On Sat, Jan 28, 2006 at 10:02:01PM +0300, Oleg Nesterov wrote: > __rcu_process_callbacks() disables interrupts to protect itself > from call_rcu() which adds new entries to ->nxtlist. > > However we can check "->nxtlist != NULL" with interrupts enabled, > we can't get "false positives" because call_rcu() can only change > this condition from 0 to 1. > > Tested with rcutorture.ko. > > Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Looks good to me.
Thanks Dipankar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |