lkml.org 
[lkml]   [2006]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 05/12] Fix oops in ufs_fill_super at mount time
    2.6.15.2 -stable review patch.  If anyone has any objections, please let 
    us know.

    ------------------

    From: Evgeniy <dushistov@mail.ru>

    There's a lack of parenthesis in fs/ufs/utils.h, so instead of the 512th
    byte of buffer, the usb2 pointer will point to the nth structure of type
    ufs_super_block_second.

    This can cause a mount-time oops if you're unlucky (especially with
    DEBUG_PAGEALLOC, which is how Alexey Dobriyan saw this problem)

    Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru>
    Acked-by: Alexey Dobriyan <adobriyan@gmail.com>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    fs/ufs/util.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- linux-2.6.15.1.orig/fs/ufs/util.h
    +++ linux-2.6.15.1/fs/ufs/util.h
    @@ -255,8 +255,8 @@ extern void _ubh_memcpyubh_(struct ufs_s
    ((struct ufs_super_block_first *)((ubh)->bh[0]->b_data))

    #define ubh_get_usb_second(ubh) \
    - ((struct ufs_super_block_second *)(ubh)-> \
    - bh[UFS_SECTOR_SIZE >> uspi->s_fshift]->b_data + (UFS_SECTOR_SIZE & ~uspi->s_fmask))
    + ((struct ufs_super_block_second *)((ubh)->\
    + bh[UFS_SECTOR_SIZE >> uspi->s_fshift]->b_data + (UFS_SECTOR_SIZE & ~uspi->s_fmask)))

    #define ubh_get_usb_third(ubh) \
    ((struct ufs_super_block_third *)((ubh)-> \
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-28 03:25    [W:0.032 / U:60.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site