lkml.org 
[lkml]   [2006]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: More information on scsi_cmd_cache leak... (bisect)
    From
    Date
    On Fri, 2006-01-27 at 13:06 -0600, Mike Christie wrote:
    > It does not have anything to do with this in scsi_io_completion does it?
    >
    > if (blk_complete_barrier_rq(q, req, good_bytes >> 9))
    > return;
    >
    > For that case the scsi_cmnd does not get freed. Does it come back around
    > again and get released from a different path?

    It looks such a likely candidate, doesn't it. Unfortunately, Tejun Heo
    removed that code around 6 Jan (in [BLOCK] update SCSI to use new
    blk_ordered for barriers), so if it is that, then the latest kernels
    should now not be leaking.

    However, all the avaliable evidence does seem to point to the write
    barrier enforcement. I'll take another look over those code paths.

    James


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-27 20:23    [W:0.023 / U:119.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site