lkml.org 
[lkml]   [2006]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[RFC: -mm patch] drivers/serial/jsm/: cleanups
    On Tue, Jan 24, 2006 at 11:24:06PM -0800, Andrew Morton wrote:
    >...
    > Changes since 2.6.16-rc1-mm2:
    >...
    > +jsm-update-for-tty-buffering-revamp.patch
    >...
    > Misc.
    >...


    This patch contains the following cleanups:
    - jsm_driver.c: remove the now unused jsm_rawreadok module_param
    - jsm_tty.c: remove a now unused variable

    Is there any problem with removing the now useless jsm_rawreadok
    module_param?


    Signed-off-by: Adrian Bunk <bunk@stusta.de>

    ---

    drivers/serial/jsm/jsm.h | 1 -
    drivers/serial/jsm/jsm_driver.c | 3 ---
    drivers/serial/jsm/jsm_tty.c | 1 -
    3 files changed, 5 deletions(-)

    --- linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm.h.old 2006-01-25 23:15:38.000000000 +0100
    +++ linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm.h 2006-01-25 23:15:43.000000000 +0100
    @@ -380,7 +380,6 @@
    extern struct uart_driver jsm_uart_driver;
    extern struct board_ops jsm_neo_ops;
    extern int jsm_debug;
    -extern int jsm_rawreadok;

    /*************************************************************************
    *
    --- linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm_driver.c.old 2006-01-25 23:15:51.000000000 +0100
    +++ linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm_driver.c 2006-01-25 23:15:57.000000000 +0100
    @@ -49,11 +49,8 @@
    };

    int jsm_debug;
    -int jsm_rawreadok;
    module_param(jsm_debug, int, 0);
    -module_param(jsm_rawreadok, int, 0);
    MODULE_PARM_DESC(jsm_debug, "Driver debugging level");
    -MODULE_PARM_DESC(jsm_rawreadok, "Bypass flip buffers on input");

    static int jsm_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent)
    {
    --- linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm_tty.c.old 2006-01-25 23:19:13.000000000 +0100
    +++ linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm_tty.c 2006-01-25 23:19:35.000000000 +0100
    @@ -512,7 +512,6 @@
    int flip_len = 0;
    int len = 0;
    int n = 0;
    - char *buf = NULL;
    int s = 0;
    int i = 0;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-26 23:26    [W:0.041 / U:61.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site