Messages in this thread | | | Date | Tue, 24 Jan 2006 09:09:37 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] swsusp: use bytes as image size units |
| |
On Po 23-01-06 18:56:42, Dave Jones wrote: > On Tue, Jan 24, 2006 at 12:32:26AM +0100, Rafael J. Wysocki wrote: > > Hi, > > > > This patch makes swsusp use bytes as the image size units, which is needed > > for future compatibility. > > With what ? I don't see how clipping this range to a maximum of 4GB > will future-proof anything. What happens in a few years time when > I want to suspend my 8GB laptop ?
With rest of suspend code, which uses bytes because depending on PAGE_SIZE is just too ugly. Notice that image size is smaller than half of lowmem, by design, so thats okay.
In unlikely case of 8GB 32-bit laptop, either suspend image fits into lowmem, or you are out of luck... Also notice that kernel is allowed to use bigger image than size limit if it can not shrink image further. Current code is equivalent with always having limit of 0.
Pavel -- Thanks, Sharp! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |