This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Tue May 7 00:39:14 2024 Delivery-date: Mon, 23 Jan 2006 09:04:51 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751409AbWAWIE0 (ORCPT ); Mon, 23 Jan 2006 03:04:26 -0500 Received: from smtp.osdl.org ([65.172.181.4]:45709 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751408AbWAWIEZ convert rfc822-to-8bit (ORCPT ); Mon, 23 Jan 2006 03:04:25 -0500 Received: from shell0.pdx.osdl.net (fw.osdl.org [65.172.181.6]) by smtp.osdl.org (8.12.8/8.12.8) with ESMTP id k0N84IDZ003365 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Mon, 23 Jan 2006 00:04:19 -0800 Received: from bix (shell0.pdx.osdl.net [10.9.0.31]) by shell0.pdx.osdl.net (8.13.1/8.11.6) with SMTP id k0N84HVU013253; Mon, 23 Jan 2006 00:04:18 -0800 Date: Mon, 23 Jan 2006 00:04:01 -0800 From: Andrew Morton To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, axboe@suse.de, jesper.juhl@gmail.com Subject: Re: [PATCH] ide-tape: attempt to handle copy_*_user() failures [take two] Message-Id: <20060123000401.144e2ca2.akpm@osdl.org> In-Reply-To: <200601222251.56185.jesper.juhl@gmail.com> References: <200601222251.56185.jesper.juhl@gmail.com> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Spam-Status: No, hits=-3 required=5 tests=PATCH_SUBJECT_OSDL X-Spam-Checker-Version: SpamAssassin 2.63-osdl_revision__1.66__ X-MIMEDefang-Filter: osdl$Revision: 1.129 $ X-Scanned-By: MIMEDefang 2.36 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org Jesper Juhl wrote: > > Second attempt at this patch. > > ( > noticed a small flaw in my first patch, this should be better. > also noticed that Gadi Oxman seems unable to recieve mail at the address > listed in MAINTAINERS, so put a few other (hopefully relevant) people on > Cc instead > ) > > > Attempt to handle copy_*_user() failures in > drivers/ide/ide-tape.c::idetape_copy_stage_*_user > > drivers/ide/ide-tape.c:2663: warning: ignoring return value of opy_from_user', declared with attribute warn_unused_result > drivers/ide/ide-tape.c:2690: warning: ignoring return value of opy_to_user', declared with attribute warn_unused_result > > Due to lack of hardware I'm unfortunately not able to test this patch > beyond making sure it compiles. > Too scary for me. > @@ -2669,26 +2671,30 @@ static void idetape_copy_stage_from_user > if (bh) > atomic_set(&bh->b_count, 0); > } > + if (not_copied) > + return not_copied; > } > tape->bh = bh; > + return 0; > } What are the effects of not updating tape->bh? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/