Messages in this thread | | | Date | Mon, 2 Jan 2006 14:43:45 +0100 | From | Adrian Bunk <> | Subject | Re: [patch 00/2] improve .text size on gcc 4.0 and newer compilers |
| |
On Mon, Jan 02, 2006 at 11:48:22AM +0100, Arjan van de Ven wrote: > > > > Your uninline patch might be simple, but the safe way would be Arjan's > > > approach to start removing all the buggy inline's from .c files. > > > > sure, that's another thing to do, but it's also clear that there's no > > reason to force inlines in the -Os case. > > > > There are 22,000+ inline functions in the kernel right now (inlined > > about a 100,000 times), and we'd have to change _thousands_ of them. > > They are causing an unjustified code bloat of somewhere around 20-30%. > > (some of them are very much justified, especially in core kernel code) > > my patch attacks the top bloaters, and gains about 30k to 40k (depending > on compiler). Gaining the other 300k is going to be a LOT of churn, not > just in amount of work... so to some degree my patch shows that it's a > bit of a hopeless battle.
A quick grep shows at about 10.000 inline's in .c files, and nearly all of them should be removed.
Yes this is a serious amount of work, but it's an ideal janitorial task.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |