Messages in this thread | | | From | Kumar Gala <> | Subject | Re: [PATCH] powerpc: remove useless spinlock from mpc83xx watchdog | Date | Thu, 19 Jan 2006 08:21:14 -0600 |
| |
On Jan 19, 2006, at 3:49 AM, Alan Cox wrote:
> On Iau, 2006-01-19 at 00:58 -0600, Kumar Gala wrote: >> Since we can only open the watchdog once having a spinlock to protect >> multiple access is pointless. >> >> Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > > NAK > > This is a common mistake. > > open is called on the open() call and is indeed in this case 'single > open', but file handles can be inherited and many users may have > access > to a single file handle. > > eg > > f = open("/dev/watchdog", O_RDWR); > fork(); > while(1) { > write(f, "Boing", 5); > } > > Alan
Thanks, you learn something new every day.
- kumar
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |