lkml.org 
[lkml]   [2006]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [linux-usb-devel] Re: [PATCH] hci_usb: implement suspend/resume
    On Wed, Jan 18, 2006 at 04:34:08PM +0100, Oliver Neukum wrote:
    > Am Mittwoch, 18. Januar 2006 15:13 schrieb Johannes Berg:
    > > On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote:
    > >
    > > > This patch is wrong. usb_kill_urb() will sleep. You must not use it under
    > > > a spinlock.
    > >
    > > Whoops. Good catch. I'll have to analyse the logic with the lists being
    > > used here (and probably add a temporary list). Will try to get a new
    > > patch until tomorrow.
    > >
    > > [side note: how about adding might_sleep() to usb_kill_urb? Then I'd at
    > > least have noticed this right away]
    >
    > Good idea.

    Done.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-18 21:49    [W:0.020 / U:60.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site