lkml.org 
[lkml]   [2006]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/4] SATA ACPI build (applies to 2.6.16-git9)
    From
    Date
    On Llu, 2006-01-16 at 23:46 +0100, Jens Axboe wrote:
    > > If you really need this enabled to be able to use suspend/resume at
    > > all, you could add a line like:
    > >
    > > It's safe to say Y. If you say N, you might get serious disk
    > > corruption when you suspend your machine.
    >
    > That's simply not true. If you say N (if you could), you could risk
    > having a non-responsive disk after resume. However, it would have been
    > synced a suspend time so you wont corrupt anything.

    If you do not execute the ACPI taskfiles for the device and you are
    doing an ACPI suspend you are in completely undefined space. Whether it
    eats your disk or not is a question of probabilities only. Yes its
    unlikely but you are in undefined space so "won't corrupt anything"
    indicates an inappropriate level of certainty.

    Fortunately it is better than the old PATA layer where as far as I can
    tell if the BIOS resume restores the BIOS HPA setup you may actually end
    up doing more damage by running ACPI taskfiles as we don't appear to
    restore enough drive state.

    Alan


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-16 23:59    [W:2.729 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site