Messages in this thread | | | Date | Mon, 16 Jan 2006 16:44:50 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH 1/4] SATA ACPI build (applies to 2.6.16-git9) |
| |
On Mon, Jan 16 2006, Randy.Dunlap wrote: > On Mon, 16 Jan 2006, Jens Axboe wrote: > > > On Fri, Jan 13 2006, Randy.Dunlap wrote: > > > From: Randy Dunlap <randy_d_dunlap@linux.intel.com> > > > > > > Add ata_acpi in Makefile and Kconfig. > > > Add ACPI obj_handle. > > > Add ata_acpi.c to libata kernel-doc template file. > > > > Randy, > > > > Any chance you can add PATA support as well for this? Many of the > > notebooks out there with SATA controllers really have PATA devices > > behind a bridge, I think it's pretty much a pre-requisite for this to be > > considered complete that this is supported as well. The code should be > > the same, it just needs to lookup the right taskfiles. Right now on this > > T43, it finds nothing. > > I'll add that to my list but I don't yet think that it's quite > as simple as you make it sound...
It might not be, I'm totally acpi clueless :-)
But the code factoring should look something like this:
- Lookup taskfiles needed for resume (and suspend might need some, too?). This step requires looking for sata and pata taskfiles listed, so you'd need code for both.
- Submit and check status of said taskfiles. This step is independent of the drive type.
So step 1 is the one that needs extending, how much work that is I dunno since I have no clue on the actual lookup or the acpi data.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |