Messages in this thread | | | Date | Sat, 14 Jan 2006 18:15:14 +0500 | From | "Alexander E. Patrakov" <> | Subject | Re: [PATCH] INPUT: add MODALIAS to the event environment |
| |
Kay Sievers wrote:
>On Sat, Jan 14, 2006 at 10:14:00AM +0500, Alexander E. Patrakov wrote: > > >>Greg KH wrote: >> >> >>>[PATCH] INPUT: add MODALIAS to the event environment >>> >>>input: add MODALIAS to the event environment >>> >>> >>Could you please tell me sample modaliases for a number of "common" >>devices (like a PS/2 mouse)? >> >>I ask because earlier (namely, in >>http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/old/gregkh-all-2.6.15.patch) >>such modaliases contained commas (",") and comma is not a "trusted" >>character in Udev (see replace_untrusted_chars() in udev_utils_string.c). >>Thus, such modaliases were mangled and didn't work. >> >> > >Only if you read it with $sysfs{modalias}, it's available in $env{MODALIAS} >and does not get mangled there, right? If you have problems with that, >let us know and we will fix it. > > With the old gregkh-all-2.6.15.patch, I have:
sh-3.1# cat /sys/class/input/input1/modalias input:b0011v0002p0004e0000-e0,1,2,k110,111,112,113,114,r0,1,8,amlsfw sh-3.1# echo "add" >/sys/class/input/input1/uevent sh-3.1# cat /events/1663 PHYSDEVPATH=/devices/platform/i8042/serio0 EV=7 SUBSYSTEM=input DEVPATH=/class/input/input1 NAME="GenPS/2 Genius <NULL>" ACTION=add PWD=/ UDEV_LOG=7 REL=103 KEY=1f0000 0 0 0 0 0 0 0 0 UDEVD_EVENT=1 SHLVL=1 PHYSDEVDRIVER=psmouse PHYS="isa0060/serio1/input0" PRODUCT=11/2/4/0 PHYSDEVBUS=serio SEQNUM=1663 _=/usr/bin/env
i.e., there is the "modalias" file in sysfs but no $MODALIAS in the environment. Is this the problem that your patch solves (note: I haven't tried it yet)?
-- Alexander E. Patrakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |