lkml.org 
[lkml]   [2006]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.15-mm3 - disk quotas apparently busticated..
Jan Kara <jack@suse.cz> wrote:
>
> > + } else {
> > + *errp = 0;
> > }
> > return bh;
> > }
> > err:
> > return NULL;
> > }
> Yup, that patch seems to be correct. I'm not sure if Andrew has picked
> up the patch as it is missing Signed-off-by and also directory of the
> file being patched (see Documentation/SubmittingPatches for general
> guidelines). So if Andrew has not responded yet, regenerate the patch
> and send it to him please. Thanks for the fix.

We ended up with this:

--- devel/fs/ext3/inode.c~ext3-get-blocks-maping-multiple-blocks-at-a-once-ext3_getblk-fix 2006-01-13 12:34:37.000000000 -0800
+++ devel-akpm/fs/ext3/inode.c 2006-01-13 12:35:39.000000000 -0800
@@ -899,8 +899,16 @@ struct buffer_head *ext3_getblk(handle_t
dummy.b_state = 0;
dummy.b_blocknr = -1000;
buffer_trace_init(&dummy.b_history);
- *errp = ext3_get_blocks_handle(handle, inode, block, 1, &dummy, create, 1);
- if ((*errp == 1 ) && buffer_mapped(&dummy)) {
+ err = ext3_get_blocks_handle(handle, inode, block, 1,
+ &dummy, create, 1);
+ if (err == 1) {
+ err = 0;
+ } else if (err >= 0) {
+ WARN_ON(1);
+ err = -EIO;
+ }
+ *errp = err;
+ if (!err && buffer_mapped(&dummy)) {
struct buffer_head *bh;
bh = sb_getblk(inode->i_sb, dummy.b_blocknr);
if (!bh) {
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-01-14 22:48    [W:0.036 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site