Messages in this thread | | | Subject | Re: [patch 5/13] s390: show_task oops. | From | Martin Schwidefsky <> | Date | Fri, 13 Jan 2006 09:45:42 +0100 |
| |
On Thu, 2006-01-12 at 16:58 -0800, Andrew Morton wrote: > Martin Schwidefsky <schwidefsky@de.ibm.com> wrote: > > > > From: Heiko Carstens <heiko.carstens@de.ibm.com> > > > > [patch 5/13] s390: show_task oops. > > > > The show_task function walks the kernel stack backchain of > > processes assuming that the processes are not running. Since > > this assumption is not correct walking the backchain can lead > > to an addressing exception and therefore to a kernel hang. > > So prevent the kernel hang (you still get incorrect results) > > verity that all read accesses are within the bounds of the > > kernel stack before performing them. > > > > This one needs to be thought about and tested versus the just-merged > s390-task_stack_page.patch. I guess it'll still work, but some of the > pretty new accessors could be used in there, at least.
Oh yes, didn't notice that Al Viro's task_thread_info() changes got merged in the meantime. We'll test & send a follow-up patch.
-- blue skies, Martin
Martin Schwidefsky Linux for zSeries Development & Services IBM Deutschland Entwicklung GmbH
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |