Messages in this thread | | | Date | Thu, 12 Jan 2006 07:17:41 -0800 | From | "Paul E. McKenney" <> | Subject | Re: [Lse-tech] Re: [ckrm-tech] Re: [PATCH 00/01] Move Exit Connectors |
| |
On Thu, Jan 12, 2006 at 06:50:34PM +1100, Keith Owens wrote: > "Paul E. McKenney" (on Wed, 11 Jan 2006 22:51:15 -0800) wrote: > >On Thu, Jan 12, 2006 at 05:19:01PM +1100, Keith Owens wrote: > >> OK, I have thought about it and ... > >> > >> notifier_call_chain_lockfree() must be called with preempt disabled. > >> > >Fair enough! A comment, perhaps? In a former life I would have also > >demanded debug code to verify that preemption/interrupts/whatever were > >actually disabled, given the very subtle nature of any resulting bugs... > > Comment - OK. Debug code is not required, the reference to > smp_processor_id() already does all the debug checks that > notifier_call_chain_lockfree() needs. CONFIG_PREEMPT_DEBUG is your > friend.
Ah, debug_smp_processor_id(). Very cool!!!
Thanx, Paul - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |