Messages in this thread | | | Subject | Re: [PATCH 4/10] NTP: precalculate time_adj from frequency | From | john stultz <> | Date | Wed, 11 Jan 2006 18:36:44 -0800 |
| |
On Thu, 2005-12-22 at 00:22 +0100, Roman Zippel wrote: > This adds the frequency part to ntp_update_frequency(). It basically > calculates from tick_usec and time_freq how many nsec the time should be > advanced per second and converts it into the nsec and fraction per tick > (tick_nsec and time_adj). > Precalculating these values allows to be more precise and avoids the > crude time_freq to time_adj conversion in second_overflow().
This patch looks ok as well, although would you consider renaming time_adj to something like phase_adj? Also maybe include a larger comment about how tick_nsec and phase_adj store the ntp adjustment, just to make it obvious that they are the cumulative result of the adjtimex() offset, freq, tick and singleshot offset values?
thanks -john
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |