Messages in this thread | | | From | Andi Kleen <> | Subject | Re: 2.6.15-git7 oopses in ext3 during LTP runs II - more problems | Date | Thu, 12 Jan 2006 01:55:26 +0100 |
| |
On Wednesday 11 January 2006 22:27, Arjan van de Ven wrote: > > 15/fs/ext3/super.c~ 2006-01-11 21:54:13.000000000 +0100 > > > +++ linux-2.6.15/fs/ext3/super.c 2006-01-11 21:54:13.000000000 +0100 > > > @@ -2150,7 +2150,7 @@ > > > > > > static void ext3_write_super (struct super_block * sb) > > > { > > > - if (mutex_trylock(&sb->s_lock) != 0) > > > + if (!mutex_trylock(&sb->s_lock) != 0) > > > BUG(); > > > sb->s_dirt = 0; > > > } > > > > We expect the lock to be held on entry. Hence we expect mutex_trylock() > > to return zero. > > you are correct, and the x86-64 mutex.h is buggy
While this patch seemed to fix LTP my desktop running the same kernel (with mutex fix) hung the mailer while sending an unrelated mail. Again on ext3.
I unfortunately don't have the backtraces anymore because I couldn't save them to disk before the reboot (and forgot to copy them to another system sorry), but they were also hanging in some JBD/ext3 functions in D, with all disk accesses hanging.
So things appear to be still broken in ext3 land.
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |