Messages in this thread | | | Date | Wed, 11 Jan 2006 14:52:02 -0800 | From | William Lee Irwin III <> | Subject | Re: [PATCH 2/2] hugetlb: synchronize alloc with page cache insert |
| |
On Wed, Jan 11, 2006 at 04:24:23PM -0600, Adam Litke wrote: > My only concern is if I am using the correct lock for the job here.
->i_lock looks rather fishy. It may have been necessary when ->i_blocks was used for nefarious purposes, but without ->i_blocks fiddling, it's not needed unless I somehow missed the addition of some custom fields to hugetlbfs inodes and their modifications by any of these functions.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |