Messages in this thread | | | Subject | Re: [PATCH/RFC?] usb/input: Add support for fn key on Apple PowerBooks | From | Benjamin Herrenschmidt <> | Date | Thu, 12 Jan 2006 08:34:17 +1100 |
| |
On Wed, 2006-01-11 at 22:20 +0100, Michael Hanselmann wrote: > On Wed, Jan 11, 2006 at 04:07:37PM -0500, Dmitry Torokhov wrote: > > Ok, I am looking at the patch again, and I have a question - do we > > really need these 3 module parameters? If the goal is to be compatible > > with older keyboards then shouldn't we stick to one behavior? > > The old keyboard was controlled by ADB (Apple Desktop Bus) commands sent > by pbbuttonsd. That doesn't work for the USB keyboard because the > conversion is not done in hardware like with the old ones. ioctl's would > also be possible, but I'm not sure wether they would be easy to do for > USB devices. Module parameters can be changed using sysfs.
Yeah, but the question is why 3 ? I think one (on/off) is enough. Do you have any case where people actually change the other ones ?
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |