lkml.org 
[lkml]   [2006]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/5] Add MMC password protection (lock/unlock) support V3
* Anderson Briglia <anderson.briglia@indt.org.br> [060111 11:26]:
> Tony Lindgren wrote:
> > * Russell King <rmk+lkml@arm.linux.org.uk> [060111 06:44]:
> >
> >>On Wed, Jan 11, 2006 at 09:16:28AM -0400, Anderson Briglia wrote:
> >>
> >>>Russell King wrote:
> >>>
> >>>
> >>>>On Mon, Jan 09, 2006 at 06:15:00PM -0400, Anderson Briglia wrote:
> >>>>
> >>>>
> >>>>
> >>>>>When a card is locked, only commands from the "basic" and "lock card" classes
> >>>>>are accepted. To be able to use the other commands, the card must be unlocked
> >>>>>first.
> >>>>>
> >>>>>
> >>>>
> >>>>I don't think this works as you intend.
> >>>>
> >>>>When a card is initially inserted, we discover the cards via mmc_setup()
> >>>>and mmc_discover_cards(). This means that we'll never set the locked
> >>>>status for newly inserted cards.
> >>>>
> >>>>
> >>>
> >>>mmc_setup() calls mmc_check_cards(). Our patch adds the necessary code
> >>>to mmc_check_cards() to set the locked state when the card is locked.
> >>
> >>Not in Linus' kernel, it doesn't.
> >>
> >>If you're working off the OMAP tree, bear in mind that I've found in
> >>the past that they have a large number of wrong or inappropriate
> >>changes to the MMC layer in there. They don't regularly merge either,
> >>and they certainly don't forward any bug fixes for review in a timely
> >>manner.
> >
> >
> > I agree the omap MMC driver should be cleaned-up and finally merged.
> >
> > Anderson, since you are already patching it, do you want to take care of
> > cleaning it up a bit and posting it here?
>
> OK Tony. I'll do it and post here asap.

Cool, thanks!

Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-01-11 20:52    [W:0.040 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site